Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Issues with RDS Compositions and Example. #191

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

elamaran11
Copy link
Contributor

@elamaran11 elamaran11 commented May 8, 2024

What does this PR do?

This PR is to fix the issues with RDS Compositions and examples :

  1. Engine version is fixed to update the depracated version. Depracated version no longer works and MR resource fails.
  2. Fixing issue with password auto generation which is not working. Password auto generation is no longer supported and MOR resource fails.
  3. Adding right namespace to passwords with password snippet for postgres example

Motivation

Make RDS Compositions work.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@elamaran11
Copy link
Contributor Author

@candonov Please merge this PR>

Copy link
Contributor

@candonov candonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@candonov candonov merged commit 34d0121 into awslabs:main Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants