-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: github pages build #195
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d77c876
fixing the github pages to use readme
edgarsilva948 bde46dd
fixing getting started to point to the readme
edgarsilva948 465a024
removing empty lines
edgarsilva948 ca2bc0a
adding raw and endraw tags
edgarsilva948 aa26bba
fixing mkdocs file
edgarsilva948 08c4327
fixing ci file to install deps
edgarsilva948 3ed12a9
fixing syntax error in the pip install
edgarsilva948 aa3871d
adding back the index file
edgarsilva948 1344d25
fixing broken link
edgarsilva948 e70d785
fixing github org
edgarsilva948 da29ef4
adding gatekeeper to a dedicated addon module
edgarsilva948 4a862f6
adding the Kubernetes and Control Plane dashboards
edgarsilva948 64a02b8
adding the argocd pod monitor
edgarsilva948 fc6bd5a
adjusting podmonitor to servicemonitor
edgarsilva948 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,5 @@ kubeconfig_* | |
*.tfplan | ||
|
||
cluster-keys.json | ||
|
||
.vscode |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,16 @@ prometheus: | |
podMetricsEndpoints: | ||
- port: "metrics" | ||
selector: {} | ||
additionalServiceMonitors: | ||
- name: "argocd" | ||
namespaceSelector: | ||
matchNames: | ||
- "argocd" | ||
endpoints: | ||
- port: "metrics" | ||
selector: | ||
matchLabels: | ||
prometheus.io/scrape: "true" | ||
grafana: | ||
service: | ||
type: "LoadBalancer" | ||
|
@@ -56,3 +66,11 @@ grafana: | |
gnetId: 14584 | ||
revision: 1 | ||
datasource: prometheusdatasource | ||
eks: | ||
gnetId: 14623 | ||
revision: 1 | ||
datasource: prometheusdatasource | ||
ekscontrolplane: | ||
gnetId: 21192 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice one! The instances and control plane nodes version can be timeseries count and the version in the legend. With 3 nodes is ok but 300 would be hard to see. Merging this PR is not dependent on that update. |
||
revision: 1 | ||
datasource: prometheusdatasource |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{% | ||
include-markdown "../README.md" | ||
%} | ||
%} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works but the addon doesn't, can you file an issue on the addon repo and link here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the Gatekeeper deployment's liveness probe doesn't have an initialDelaySeconds set, or it's too low. This can be a problem when not all cluster pods (like coredns, vpc-cpi, etc.) are up and running right away. If Gatekeeper starts too early, it doesn’t retry enough times and fail.
To work around this, I added a dependency, forcing Gatekeeper to wait until all the addons are up and running, which seems to work now. I will see if I can open a PR to adjust this in the addon repo.