This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Ignoring masking layer test for RNN with MXNet backend #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roywei
reviewed
Mar 29, 2019
tests/keras/layers/recurrent_test.py
Outdated
| @pytest.mark.skipif(K.backend() == 'mxnet', | ||
| reason='MXNet backend has an issue with Masking layer' | ||
| 'Tracking with this issue:' | ||
| 'https://github.com/awslabs/keras-apache-mxnet/issues/228') |
There was a problem hiding this comment.
can you enable this test for unroll=True?
you can do the check in the test and don't execute the part that unroll=False
There was a problem hiding this comment.
Done. Can you please check it again?
There was a problem hiding this comment.
The test_masking_correctness() runs only with unroll=False so skipping the whole test. However test_masking_layer() runs with unroll=True and unroll=False, so skipped the unroll=False test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is an issue with the Masking Layer in RNN with MXNet backend after this PR #14192 got merged into MXNet master branch. Ignoring those test for now to let the nightly build pass. I have created a separate issue #228 to track the masking layer issue.