Fix/m policies #447
Merged
Fix/m policies #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b1e7e9f.
| @@ -313,6 +327,14 @@ def deploy_module_stack( | |||
|
|
|||
| _logger.debug("project_managed_policy_output is : %s", stack_outputs) | |||
| if project_managed_policy_stack_exists: | |||
| if stack_outputs.get("StackStatus") and "_IN_PROGRESS" in stack_outputs.get("StackStatus"): | |||
| _logger.info("The managed policy stack is not complete, waiting 60 seconds") | |||
| time.sleep(60) | |||
There was a problem hiding this comment.
as discussed offline, its good to have this refactored with retry logic, while sleeping for 30 seconds
| else: | ||
| _logger.debug("project_managed_policy_output is : %s", stack_outputs) | ||
| project_managed_policy_arn = stack_outputs.get("ProjectPolicyARN", None) | ||
| retries = -1 |
There was a problem hiding this comment.
why should it retry once the project_managed_policy_arn is obtained? shoudn't this be break out of the while loop?
There was a problem hiding this comment.
it is not...it is setting the retries value to -1
| retries = -1 | ||
| else: | ||
| _logger.debug("project_managed_policy_output does not exist") | ||
| retries = -1 |
There was a problem hiding this comment.
Need for this retry?
we should retry only when the managed policy stack is in "*IN_PROGRESS" state
There was a problem hiding this comment.
this signals to break out of the loop... sets retries equal to -1
srinivasreddych
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#445
Description of changes:
Only try to delete the managed policy of no roles are attached
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.