Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA-512 support #814

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conversation

fghanmi
Copy link

@fghanmi fghanmi commented Aug 30, 2024

Issue #, if available: #813

Description of changes:
Currently only SHA-256 is supported. This PR is going to:

  • Implement SHA-512 support alongside the existing SHA-256.
  • Ensure backward compatibility with existing systems that rely on SHA-256.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fghanmi fghanmi force-pushed the feature/sha512 branch 2 times, most recently from bb9e9de to d8b3378 Compare August 30, 2024 10:13
@jpculp jpculp self-requested a review September 3, 2024 18:52
@jpculp
Copy link
Contributor

jpculp commented Sep 3, 2024

Thank you for the contribution! I'm going to get some extra eyes on this as well as your other PR.

@jpculp
Copy link
Contributor

jpculp commented Sep 3, 2024

Looks like you're hitting some clippy lints. If you run make build with the latest stable Rust as the default you'll be able to verify locally.

Copy link
Contributor

@jpculp jpculp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fghanmi, would it be possible to include a unit test for this change? We can also have someone on our end take care of it if you'd prefer.

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Copy link

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root metadata in tough/tests/data/tuf-sha512/metadata/ is still expiring next month

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
@fghanmi fghanmi requested review from jku and jpculp October 17, 2024 10:12
@jpculp
Copy link
Contributor

jpculp commented Nov 15, 2024

Hi @fghanmi. Thank you for your patience on this. I think we're in a good place here. Would you be willing to squash your commits to one for the tough changes and one for tuftool? We can also do it on our end if you would prefer.

@fghanmi
Copy link
Author

fghanmi commented Nov 18, 2024

Hi @fghanmi. Thank you for your patience on this. I think we're in a good place here. Would you be willing to squash your commits to one for the tough changes and one for tuftool? We can also do it on our end if you would prefer.

@jpculp , Thank you!
regarding the squash, I see that the changes on tuftool are only on tuftool/tests/, and one commit does have changes on both tuftool and tough (which is required to have successful tests) - I am really not sure how to organize the commits in this case..

@jpculp
Copy link
Contributor

jpculp commented Nov 18, 2024

@fghanmi, that's true. It might make the most sense to keep it as one commit despite it crossing over.

@fghanmi
Copy link
Author

fghanmi commented Nov 18, 2024

@fghanmi, that's true. It might make the most sense to keep it as one commit despite it crossing over.

So squashing to 1 commit is okay ?

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
@fghanmi
Copy link
Author

fghanmi commented Nov 27, 2024

@jpculp I've added another commit to always consider adding targets/sha512_hash.target_filename
If this change is okay for you, I will squash the commits as agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants