-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SHA-512 support #814
base: develop
Are you sure you want to change the base?
Add SHA-512 support #814
Conversation
bb9e9de
to
d8b3378
Compare
Thank you for the contribution! I'm going to get some extra eyes on this as well as your other PR. |
Looks like you're hitting some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fghanmi, would it be possible to include a unit test for this change? We can also have someone on our end take care of it if you'd prefer.
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
1fb0357
to
1426f1c
Compare
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root metadata in tough/tests/data/tuf-sha512/metadata/ is still expiring next month
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Hi @fghanmi. Thank you for your patience on this. I think we're in a good place here. Would you be willing to squash your commits to one for the |
@jpculp , Thank you! |
@fghanmi, that's true. It might make the most sense to keep it as one commit despite it crossing over. |
So squashing to 1 commit is okay ? |
@fghanmi, looking closer at the TUF spec, we might need to tweak the approach here. I saw this interesting excerpt from 6.2.1. (This is if we have sha256 AND sha512 at the same time) |
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
@jpculp I've added another commit to always consider adding |
Issue #, if available: #813
Description of changes:
Currently only SHA-256 is supported. This PR is going to:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.