-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes gh-697 Enhance SqsAutoConfiguration to use an available ObjectM… #845
Conversation
… ObjectMapper for SqsContainerOptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @mmaeller! Looks good, but there's an issue with the formatting that's creating lots of diffs.
Can you please fix that?
Thanks!
assertThat(options.getMessageConverter()).isInstanceOfSatisfying( | ||
SqsMessagingMessageConverter.class, | ||
messageConverter -> assertThat(messageConverter.getPayloadMessageConverter()) | ||
.isInstanceOfSatisfying(CompositeMessageConverter.class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very long chain, perhaps if we use extracting
instead of isInstanceOfSatisfying
we could make it simpler?
assertThat(options.getMaxConcurrentMessages()).isEqualTo(10); | ||
assertThat(options.getMaxMessagesPerPoll()).isEqualTo(10); | ||
assertThat(options.getPollTimeout()).isEqualTo(Duration.ofSeconds(10)); | ||
assertThat(options.getMessageConverter()).isInstanceOfSatisfying( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, please let's try to simplify this a bit.
@tomazfernandes I made the requested changes in a new PR: #906 - I really would like this released and it seems the original author hasn't had time. :-) |
Hi @postalservice14, Thank you for the adjustments. |
📢 Type of change
📜 Description
See #697 (reply in thread)
💡 Motivation and Context
Please see #697
💚 How did you test it?
See extended unit tests.
📝 Checklist
🔮 Next steps