Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Check if bucket exists with S3Template #915

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Feature: Check if bucket exists with S3Template #915

merged 2 commits into from
Nov 1, 2023

Conversation

straurob
Copy link
Contributor

@straurob straurob commented Oct 20, 2023 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Added a method to the S3Template which allows to check if a bucket exists by a given bucket name. The method returns a simple boolean.

💡 Motivation and Context

Please refer to #901

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: s3 S3 integration related issue label Oct 20, 2023
@straurob straurob changed the title feat: check if bucket exists with S3Template Feature: Check if bucket exists with S3Template Oct 21, 2023
@maciejwalkowiak maciejwalkowiak added this to the 3.0.3 milestone Oct 23, 2023
maciejwalkowiak
maciejwalkowiak approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @straurob!

@maciejwalkowiak maciejwalkowiak merged commit 0a176d0 into awspring:main Nov 1, 2023
4 checks passed
@straurob straurob deleted the bucket-exists-901 branch November 1, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatejNedic MatejNedic MatejNedic approved these changes

@maciejwalkowiak maciejwalkowiak maciejwalkowiak approved these changes

@tomazfernandes tomazfernandes Awaiting requested review from tomazfernandes tomazfernandes is a code owner

Assignees
No one assigned
Labels
component: s3 S3 integration related issue
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@straurob @maciejwalkowiak @MatejNedic