Fix startup when only base starter is included in classpath. #955
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtup when only base starter is included in classpath. Fixes #934
maciejwalkowiak
requested review from
MatejNedic and
tomazfernandes
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
maxjiang153
reviewed
Nov 15, 2023
| @@ -18,18 +18,22 @@ | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-autoconfigure</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>software.amazon.awssdk</groupId> | |||
| <artifactId>aws-core</artifactId> | |||
There was a problem hiding this comment.
Should this dependency be added to the spring-cloud-aws-core module?
There was a problem hiding this comment.
The autoconfigure module unfortunately depends on it in Config Resolvers.
maciejwalkowiak
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit
sdk-coredependency to autoconfigure module to fix startup when only base starter is included in classpath.Fixes #934