Clean up #35
Closed
Clean up #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForTehLose
commented
Nov 8, 2023
| @@ -162,7 +162,8 @@ impl Plugin for OpenXrPlugin { | |||
| let mut manual_texture_views = app.world.resource_mut::<ManualTextureViews>(); | |||
| manual_texture_views.insert(LEFT_XR_TEXTURE_HANDLE, left); | |||
| manual_texture_views.insert(RIGHT_XR_TEXTURE_HANDLE, right); | |||
| drop(manual_texture_views); | |||
| //drop non drop | |||
| //drop(manual_texture_views); | |||
There was a problem hiding this comment.
this was a change I wasn't sure of
There was a problem hiding this comment.
yea this seems fine to just remove. Probably leftover from an older bevy version where this was Drop
ForTehLose
commented
Nov 8, 2023
| @@ -31,7 +31,7 @@ pub const RIGHT_XR_TEXTURE_HANDLE: ManualTextureViewHandle = ManualTextureViewHa | |||
| /// Adds OpenXR support to an App | |||
| #[derive(Default)] | |||
| pub struct OpenXrPlugin; | |||
|
|
|||
| #[allow(clippy::type_complexity)] | |||
There was a problem hiding this comment.
I think this could be simplified, but lacked the expertise to be sure
|
This PR needs a rebase |
oli-obk
reviewed
Dec 15, 2023
| @@ -162,7 +162,8 @@ impl Plugin for OpenXrPlugin { | |||
| let mut manual_texture_views = app.world.resource_mut::<ManualTextureViews>(); | |||
| manual_texture_views.insert(LEFT_XR_TEXTURE_HANDLE, left); | |||
| manual_texture_views.insert(RIGHT_XR_TEXTURE_HANDLE, right); | |||
| drop(manual_texture_views); | |||
| //drop non drop | |||
| //drop(manual_texture_views); | |||
There was a problem hiding this comment.
yea this seems fine to just remove. Probably leftover from an older bevy version where this was Drop
| @@ -12,6 +12,7 @@ use crate::resources::{ | |||
|
|
|||
| use openxr as xr; | |||
|
|
|||
| #[allow(clippy::type_complexity)] | |||
There was a problem hiding this comment.
could add this to cargo.toml (latest Rust version has a section for it):
[lints.clippy]
type_complexity = "allow"
too_many_arguments = "allow"
|
Stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lots of clean up to enabled cargo fmt, cargo clippy, and cargo rustdoc