Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial D3D12 implementation + improvements #50

Merged
merged 10 commits into from
Feb 23, 2024
Merged

Initial D3D12 implementation + improvements #50

merged 10 commits into from
Feb 23, 2024

Conversation

SafariMonkey
Copy link
Collaborator

No description provided.

@SafariMonkey SafariMonkey mentioned this pull request Dec 1, 2023
Merged
@SafariMonkey SafariMonkey force-pushed the implement-d3d12 branch 2 times, most recently from dea5ee4 to 82a4a25 Compare December 1, 2023 20:02
TheButlah
TheButlah reviewed Dec 2, 2023
View reviewed changes
Copy link
Contributor

@TheButlah TheButlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partly went through a review, didn't have time to finish.

src/graphics/d3d12.rs Outdated Show resolved Hide resolved
src/graphics/d3d12.rs Outdated Show resolved Hide resolved
src/graphics/d3d12.rs Outdated Show resolved Hide resolved
src/graphics/d3d12.rs Outdated Show resolved Hide resolved
src/graphics/d3d12.rs Outdated Show resolved Hide resolved
src/graphics/d3d12.rs Show resolved Hide resolved
src/graphics/d3d12.rs Outdated Show resolved Hide resolved
src/graphics/d3d12.rs Show resolved Hide resolved
src/graphics/d3d12.rs Outdated Show resolved Hide resolved
@SafariMonkey
Copy link
Collaborator Author

Thank you for taking a look, @TheButlah!

I have a guest this weekend so I will make the changes when I find the time.

Most of the comments were good points but relate to things I copied from the other driver, so I'll apply those changes as separate commits that make the same change on both sides.

@SafariMonkey
Copy link
Collaborator Author

Force push was rebasing and and squashing a little

@SafariMonkey
Copy link
Collaborator Author

Squashed in removing some unused imports

@SafariMonkey SafariMonkey marked this pull request as draft December 17, 2023 14:33
@SafariMonkey
Copy link
Collaborator Author

Set as draft to reflect an outstanding issue: got errors on Vulkan on Oculus PC because it doesn't select Rgba8UnormSrgb, but instead Rgba8Unorm; need to investigate why that causes problems. Could probably change to use a hardcoded format and bail if the runtime doesn't support it if we wanna defer that work.

@TheButlah
Copy link
Contributor

Could probably change to use a hardcoded format and bail if the runtime doesn't support it if we wanna defer that work.

I suggest that approach, to prevent this PR from getting stale. I would open a subsequent PR to fix that particular issue after this is merged.

@SafariMonkey SafariMonkey force-pushed the implement-d3d12 branch 2 times, most recently from 081e049 to 396560e Compare February 23, 2024 03:12
@SafariMonkey SafariMonkey force-pushed the implement-d3d12 branch 3 times, most recently from 80c1e66 to cd1020e Compare February 23, 2024 03:26
@SafariMonkey
Make d3d12 build by default if possible
8e0837b
@SafariMonkey
Log message consistency
faa0f69
@SafariMonkey
Add error if no backend is enabled
7502fc1
@SafariMonkey
Dynamically detect D3D12 feature level
91a4f2a
@SafariMonkey
Default to dxc compiler because fxc is too slow
59ce1f5 
This does require dxil.dll and dxcompiler.dll to be available,
falling back to fxc if these cannot be found.
Can be overridden by setting the WGPU_DX12_COMPILER
environment variable to "fxc".
@SafariMonkey SafariMonkey marked this pull request as ready for review February 23, 2024 03:28
MalekiRe
MalekiRe approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@MalekiRe MalekiRe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SafariMonkey SafariMonkey merged commit dbc3a1c into awtterpip:main Feb 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheButlah TheButlah TheButlah approved these changes

@MalekiRe MalekiRe MalekiRe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SafariMonkey @TheButlah @MalekiRe