Skip to content

Commit

Permalink
engines/xnvme: fix fdp support for userspace drivers
Browse files Browse the repository at this point in the history
The xNVMe backend supports FDP commands for userspace drivers
such as SPDK. Enable support in the xnvme ioengine.
Update the xnvme fdp example file accordingly.

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Link: https://lore.kernel.org/r/20231102135928.195372-1-ankit.kumar@samsung.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
ankit-sam authored and axboe committed Nov 2, 2023
1 parent 95f4d3f commit 48cf0c6
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
2 changes: 1 addition & 1 deletion engines/xnvme.c
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,7 @@ static int xnvme_fioe_fetch_ruhs(struct thread_data *td, struct fio_file *f,
uint32_t nsid;
int err = 0, err_lock;

if (f->filetype != FIO_TYPE_CHAR) {
if (f->filetype != FIO_TYPE_CHAR && f->filetype != FIO_TYPE_FILE) {
log_err("ioeng->fdp_ruhs(): ignoring filetype: %d\n", f->filetype);
return -EINVAL;
}
Expand Down
20 changes: 20 additions & 0 deletions examples/xnvme-fdp.fio
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,26 @@
; --xnvme_sync=nvme \
; --filename=/dev/ng0n1
;
; # Use the xNVMe io-engine engine with SPDK backend, note that you have to set the Namespace-id
; fio examples/xnvme-fdp.fio \
; --section=default \
; --ioengine=xnvme \
; --xnvme_dev_nsid=1 \
; --filename=0000\\:01\\:00.0
;
; NOTE: The URI encoded in the filename above, the ":" must be escaped.
;
; On the command-line using two "\\":
;
; --filename=0000\\:01\\:00.0
;
; Within a fio-script using a single "\":
;
; filename=0000\:01\:00.0
;
; NOTE: If you want to override the default bs, iodepth, and workload, then
; invoke it as:
;
; FIO_BS="512" FIO_RW="read" FIO_IODEPTH=16 fio examples/xnvme-fdp.fio \
; --section=override --ioengine=xnvme --xnvme_sync=nvme --filename=/dev/ng0n1
;
Expand Down

0 comments on commit 48cf0c6

Please sign in to comment.