Skip to content

Commit

Permalink
engines/xnvme: only include entry-header ('libxnvme.h')
Browse files Browse the repository at this point in the history
This changes how the xNVMe fio io-engine consumes the xNVMe library by
only including the library-entry header "libxnvme.h".

From version 0.7.0 the xNVMe API headers are refactored to drop header
guards on the individual headers and abide by the idiom of "headers must
not include other headers".

The exception is the library-entry header "libxnvme.h". The
library-entry-header includes all headers provided with xNVMe, which is
a convenient approach to consuming the library. One where, in case the
API namespace grows or shrinks, then the xNVMe fio io-engine need not
change how it includes xNVMe.

However, since fio has consumed the main-entry header and individual
headers, xNVMe has held back on removing the guards on _nvm, _zns, and
_spec to avoid breaking the xNVMe fio engine. They will eventually be
deprecated. Thus, this change to consume xNVMe in the manner intended
from version v0.7.0 and onwards.

Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
  • Loading branch information
safl committed Nov 20, 2023
1 parent afdde53 commit 63f210e
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions engines/xnvme.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@
#include <stdlib.h>
#include <assert.h>
#include <libxnvme.h>
#include <libxnvme_libconf.h>
#include <libxnvme_nvm.h>
#include <libxnvme_znd.h>
#include <libxnvme_spec_fs.h>
#include "fio.h"
#include "zbd_types.h"
#include "fdp.h"
Expand Down

0 comments on commit 63f210e

Please sign in to comment.