Skip to content

Commit

Permalink
Revert "ioengines: Make td_io_queue print log_err when got error "
Browse files Browse the repository at this point in the history
We should not be making these error prints, they are purely
information, and in fact they should probably get deleted all
together.

For now, as this is actually breaking test frameworks, just revert
the change.

This reverts commit 3c826d1.

https://lore.kernel.org/fstests/20240415182231.GA2649469@mit.edu/
Reported-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
axboe committed Apr 15, 2024
1 parent 4eef23f commit 8bcd4cb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ioengines.c
Original file line number Diff line number Diff line change
Expand Up @@ -413,15 +413,15 @@ enum fio_q_status td_io_queue(struct thread_data *td, struct io_u *io_u)
if (io_u->error == EINVAL && td->io_issues[io_u->ddir & 1] == 1 &&
td->o.odirect) {

log_err("fio: first direct IO errored. File system may not "
log_info("fio: first direct IO errored. File system may not "
"support direct IO, or iomem_align= is bad, or "
"invalid block size. Try setting direct=0.\n");
}

if (zbd_unaligned_write(io_u->error) &&
td->io_issues[io_u->ddir & 1] == 1 &&
td->o.zone_mode != ZONE_MODE_ZBD) {
log_err("fio: first I/O failed. If %s is a zoned block device, consider --zonemode=zbd\n",
log_info("fio: first I/O failed. If %s is a zoned block device, consider --zonemode=zbd\n",
io_u->file->file_name);
}

Expand Down

0 comments on commit 8bcd4cb

Please sign in to comment.