Update docs to clarify how to pass job options in client mode #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run in client mode, fio does not pass any job options specified on the command line to the fio server. When run in client mode, all job options must be specified via local or remote job files. Update the docs to indicate this to avoid end-user confusion. Fixes axboe#1629 Signed-off-by: Nick Neumann nick@pcpartpicker.com
aggieNick02
force-pushed
the
fio_client_server_doc_fix
branch
from
ccab400
to
702e3f3
Compare
|
For posterity: The macOS CI job failed with runner image macos-12 v20230916.1: https://github.com/axboe/fio/actions/runs/6241938619/job/16944993465 I re-ran it and the job succeeded with runner image macos-12 v20230901.1: https://github.com/axboe/fio/actions/runs/6241938619/job/16945544582 Presumably v20230916.1 was problematic and GitHub switched things back behind the scenes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run in client mode, fio does not pass any job options specified on the command line to the fio server. When run in client mode, all job options must be specified via local or remote job files. Update the docs to indicate this to avoid end-user confusion.
Fixes #1629
Signed-off-by: Nick Neumann nick@pcpartpicker.com