Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engines/xnvme: only include entry-header ('libxnvme.h') #1673

Merged
merged 1 commit into from
Nov 20, 2023

Commits on Nov 20, 2023

  1. engines/xnvme: only include entry-header ('libxnvme.h')

    This changes how the xNVMe fio io-engine consumes the xNVMe library by
    only including the library-entry header "libxnvme.h".
    
    From version 0.7.0 the xNVMe API headers are refactored to drop header
    guards on the individual headers and abide by the idiom of "headers must
    not include other headers".
    
    The exception is the library-entry header "libxnvme.h". The
    library-entry-header includes all headers provided with xNVMe, which is
    a convenient approach to consuming the library. One where, in case the
    API namespace grows or shrinks, then the xNVMe fio io-engine need not
    change how it includes xNVMe.
    
    However, since fio has consumed the main-entry header and individual
    headers, xNVMe has held back on removing the guards on _nvm, _zns, and
    _spec to avoid breaking the xNVMe fio engine. They will eventually be
    deprecated. Thus, this change to consume xNVMe in the manner intended
    from version v0.7.0 and onwards.
    
    Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
    safl committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    63f210e View commit details
    Browse the repository at this point in the history