Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iolog: fix disk stats issue #1736

Merged
merged 1 commit into from
Mar 22, 2024
Merged

iolog: fix disk stats issue #1736

merged 1 commit into from
Mar 22, 2024

Conversation

yygcode
Copy link
Contributor

@yygcode yygcode commented Mar 20, 2024

iolog: fix disk stats issue

In the iolog replay scenario, the disk util in the td structure is
not initialized, resulting in the disk stats not being correctly
updated.

Fixes: #1735

Signed-off-by: Yong Gang yygcode@gmail.com

@vincentkfu
Copy link
Collaborator

vincentkfu commented Mar 21, 2024

  • Please use your real name in the sign off: Signed-off-by: REAL NAME <yygcode@gmail.com>
  • Also you can include above the sign off a line with Fixes: Link-to-the-issue-you-filed
  • Finally, the first line of the commit message should omit [PATCH] and instead be something like iolog: fix disk stats issue

@yygcode yygcode force-pushed the issue-1735 branch 2 times, most recently from 611b07c to 8a3db98 Compare March 22, 2024 14:30
In the iolog replay scenario, the disk util in the td structure is
not initialized, resulting in the disk stats not being correctly
updated.

Fixes: axboe#1735

Signed-off-by: Yong Gang <yygcode@gmail.com>
@yygcode
Copy link
Contributor Author

yygcode commented Mar 22, 2024

  • Please use your real name in the sign off: Signed-off-by: REAL NAME <yygcode@gmail.com>
  • Also you can include above the sign off a line with Fixes: Link-to-the-issue-you-filed
  • Finally, the first line of the commit message should omit [PATCH] and instead be something like iolog: fix disk stats issue

Thanks. All comments have been resolved.

@yygcode yygcode changed the title [PATCH] iolog: fix disk stats issue iolog: fix disk stats issue Mar 22, 2024
@axboe axboe merged commit 2b03792 into axboe:master Mar 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fio iolog replay does not report disk stats corrrectly
3 participants