Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDP fixes #1790

Closed
wants to merge 3 commits into from
Closed

FDP fixes #1790

wants to merge 3 commits into from

Conversation

ankit-sam
Copy link
Contributor

The current way of fdp ruhs initialization limited it to a maximum of 128 ruhs descriptors. Fio allows a total of 128 placement id
indices at a time, but for devices supporting more the 128 ruhs, users should have the ability to pass any 128 placement id index / indices (0 to max number of ruhs - 1). This series fixes that.

The current way of initilization limits ruhs from 0 to 127.
Although fio supports a maximum of 128 ruhs, for the files supporting
more the 128 placement ids user has the flexibility of specifying any
128 placement id index at a time. This commit updates the way we fetch
ruhs. We now fetch the ruhs info in two steps. The first step only gets
us the number of ruhs from the ioengine. This is used by fdp backend to
allocate the correct buffer size for the second step, where we fetch
the actual ruhs info.

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Use calloc instead of scalloc as ruhs buffer allocation is temporary.
Remove the restriction on maximum number of ruhs, fetch and fill the
ruhs buffer as requested by fdp backend.

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Remove the restriction on maximum number of ruhs, fetch and fill the
ruhs buffer as requested by fdp backend.

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
@vincentkfu
Copy link
Collaborator

@vincentkfu vincentkfu closed this Jul 15, 2024
@vincentkfu
Copy link
Collaborator

I will take a closer look but I think this change will allow us to get rid of FDP_MAX_RUHS.

@ankit-sam ankit-sam deleted the fdp/pid_limit_fix branch July 17, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants