Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fdp fixes #1791

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Small fdp fixes #1791

merged 3 commits into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. dataplacement: remove FDP_MAX_RUHS 

    Earlier fio used to have different limits on the max number of data
placement ID indices which user can pass, and the max number of ruhs
which can be stored. As during initialization we now fetch all the ruhs
from the device and then allocate buffer for the requested ones, there
is no need for FDP_MAX_RUHS.

Add missing error message if incorrect placement ID index is specified.

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
    @ankit-sam
    ankit-sam committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    481b6e3 View commit details
    Browse the repository at this point in the history

  2. dataplacement: change log_info to log_err for error messages 

    Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
    @ankit-sam
    ankit-sam committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6715cca View commit details
    Browse the repository at this point in the history

  3. ioengines: bump up FIO_IOOPS_VERSION 

    For fdp backend the way ruhs are fetched has been changed.
Earlier fdp_fetch_ruhs was called once with a buffer that can store
ruhs upto FDP_MAX_RUHS. The new fdp_fetch_ruhs is called twice. The
first call doesn't have any buffer for ruhs, and is only to get the
number of ruhs reported by the device. The second call has the buffer
that can store all the ruhs.

This impacts any external ioengines, so bump up FIO_IOOPS_VERSION.

Fixes: commit 56d1224 (dataplacement: update ruh info initialization)

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
    @ankit-sam
    ankit-sam committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    72fb820 View commit details
    Browse the repository at this point in the history