Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configure with --build-static option which enables static RDMA in Issue #1801 #1808

Closed
wants to merge 0 commits into from
Closed

Fix configure with --build-static option which enables static RDMA in Issue #1801 #1808

wants to merge 0 commits into from

Conversation

HuangShumin
Copy link
Contributor

Fix configure with --build-static option which enables static RDMA in Issue #1801

This pull request to probe static libibverbs/librdmacm/librpma library. It's neccessary to enable static RDMA engine build with netlink libnl-3 and libnl-route-3.

Signed-off-by: Huang Shumin longway68@qq.com

@HuangShumin HuangShumin mentioned this pull request Aug 22, 2024
Closed
@grom72
Copy link
Contributor

grom72 commented Aug 22, 2024

The librpma section should not be modified IMHO, as it is not required for RDMA, and also it is worth considering that
https://github.com/pmem/rpma has been archived and is no longer maintained.
Perhaps it will be better to remove librpma support from Fio

vincentkfu
vincentkfu reviewed Aug 27, 2024
View reviewed changes
configure Outdated
rdmacm="yes"
LIBS="$(pkg-config --static --libs librpma) $LIBS"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is librpma involved when detecting rdmacm support?

@vincentkfu
Copy link
Collaborator

@HuangShumin As mentioned by @grom72 please restrict your changes only to those that are relevant for your needs.

@grom72 I'd be happy to review a patch removing librpma support.

@HuangShumin
Copy link
Contributor Author

I recommend to fix librpma static building as well.
And then to review the pulling request to remove librpma.

How do you think? So far there does exist static building issue for librpma.

@grom72
Copy link
Contributor

grom72 commented Sep 19, 2024

librpma support has been removed: #1811

@HuangShumin
Copy link
Contributor Author

New pull reqest is submited in #1816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentkfu vincentkfu vincentkfu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuangShumin @grom72 @vincentkfu