Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup and refactor #338

Merged
merged 12 commits into from
Aug 19, 2024
Merged

chore: cleanup and refactor #338

merged 12 commits into from
Aug 19, 2024

Conversation

npty
Copy link
Member

@npty npty commented Aug 19, 2024

Description

This PR refactors the sui scripts by separating the utils files and the command program files.

Changes

  • All utils files are move into sui/utils folder and added the index.js file which exports everything there.
  • All command program files now imports the utils files from the single location, ./utils, instead of ./types-utils, cli-utils, utils, etc.
  • Removed unused file such as deploy-test.js because the Test contract deployment now becomes a part of deploy-contract.js.
  • Renamed deploy-utils.js to upgrade-utils.js because the exported functions all involve with the contract upgrade.

Test

All commands are tested manually to check if there's any error or unexpected outcome.

@npty npty self-assigned this Aug 19, 2024
@npty npty marked this pull request as ready for review August 19, 2024 07:58
@npty npty requested a review from a team as a code owner August 19, 2024 07:58
sui/utils/index.js Show resolved Hide resolved
@milapsheth milapsheth merged commit ca64dd9 into main Aug 19, 2024
4 checks passed
@milapsheth milapsheth deleted the chore/cleanup-and-refactor branch August 19, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants