feat: add sui testnet #483
Conversation
…erent implementation hash derived. could this be because of specifying owner
…ontract-deployments into feat/add-sui-testnet
| "deployer": "0x6f24A47Fc8AE5441Eb47EFfC3665e70e69Ac3F05", | ||
| "tokenManagerDeployer": "0x121b0e54Cd7ad2BBCb4c4C9275697978EBaF3653", | ||
| "tokenManagerDeployer": "0x3d36C02D7EE86F25565f319E71641CEFeD0eac81", |
There was a problem hiding this comment.
why are these changes part of this PR? Do you need to change the base branch?
| "Gateway_v0": "0x7fa977e8174494413834a2bafd5b46e07049c02d73e771bc00e58a31ef7895be::gateway_v0::Gateway_v0", | ||
| "CommandType": "0x7fa977e8174494413834a2bafd5b46e07049c02d73e771bc00e58a31ef7895be::gateway_v1::CommandType", | ||
| "Gateway": "0x7fa977e8174494413834a2bafd5b46e07049c02d73e771bc00e58a31ef7895be::gateway::Gateway", | ||
| "Gateway_v1": "0x7fa977e8174494413834a2bafd5b46e07049c02d73e771bc00e58a31ef7895be::gateway_v1::Gateway_v1" |
There was a problem hiding this comment.
why is Gateway_v1 included here? Did you use the wrong Sui release/upgradability test release instead of v1.0.1?
| "versions": [ | ||
| "0x7fa977e8174494413834a2bafd5b46e07049c02d73e771bc00e58a31ef7895be" | ||
| ], |
There was a problem hiding this comment.
make versions into a dictionary mapping version number to package id, makes it more obvious instead of relying on the implicit version index
| "OwnerCap": "0x7d71d070eeea0eeaca7a44f52747b2e9942c9d3fa921093ed5e5abd7bec5562c" | ||
| } | ||
| }, | ||
| "ITS": { |
There was a problem hiding this comment.
Why was ITS deployed? ITS release hasn't been created yet. Shouldn't include invalid contracts in the config. Was this address registered on the ITS hub as well?
| "GasServicev0": "0x737706f16c72f9110916f266714967e518868b4dbf08774c1a487b4ccc2971e8" | ||
| } | ||
| }, | ||
| "Abi": { |
There was a problem hiding this comment.
Abi is needed for ITS, so should only be deployed when ITS needs to be deployed
| "address": "axelar1kleasry5ed73a8u4q6tdeu80hquy4nplfnrntx3n6agm2tcx40fssjk7gj" | ||
| "codeId": 18, | ||
| "domainSeparator": "0xf221c54a1a478f48c840a24cf2b96f77c9bc369a40570744b8fedd91df001624", | ||
| "address": "axelar19ew05xx796gp7xkzx5z592cp0s7lg58gypaas3u2pwunmyjdyytqxq886u" |
There was a problem hiding this comment.
when deploying on mainnet, make sure the address matches
| "storeCodeProposalCodeHash": "d9412440820a51bc48bf41a77ae39cfb33101ddc6562323845627ea2042bf708", | ||
| "lastUploadedCodeId": 26 | ||
| }, | ||
| "InterchainTokenService": { |
There was a problem hiding this comment.
use the right base branch for the PR so unrelated changes aren't included
https://axelarnetwork.atlassian.net/browse/AXE-5125