fix: change ownable to SDK implementation #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanamiel
commented
Aug 11, 2023
| transferOwnership(_owner); | ||
| assembly { | ||
| sstore(_OWNER_SLOT, _owner) | ||
| } |
There was a problem hiding this comment.
Let me know if I should emit an OwnershipTransferred event here
There was a problem hiding this comment.
Yes, i think it's a good idea to emit event here since the ownership address is important enough to make it clear and transparent.
There was a problem hiding this comment.
i'd prefer creating an internal _transferOwnership method in Ownable to encapsulate this from inheriting contracts
deanamiel
force-pushed
the
fix/ownable-implementation
branch
from
4745bb9
to
be2d9d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to switch Ownable to the SDK implementation.