-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory metrics for Chrome using window.performance.memory #48
base: master
Are you sure you want to change the base?
Conversation
MemoryProbe.prototype.start = function(browser) { | ||
var me = this; | ||
this.timerHandle = setInterval(function() { | ||
browser.eval('window.performance.memory').then(function(res) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling eval with a time from webdriver usually results in an extra network call, since the webdriver would have to talk to selenium. This will require the extension to receive the "stringified" message, parse and execute it, increasing the impact of the test on the final data that we get.
Also note that when you collect memory with metrics like frames_per_sec, you may notice differences since this is additional javascript that is executed, and results in network calls. Could that be the reason you are getting some inconsistent results in your metrics ?
Did you notice a lot of difference in other data when this was enabled, as opposed to having stopped this metric ? I was wondering if this code would add noise to the data that we finally collect. |
TBH I haven't compared these results to the previous ones. Fortunately they are readily available in the benchmarks repo (https://github.com/auth0/blog-dombench). I will take a look when I have some time (probably tomorrow) and post my findings here. |
@axemclion have you had a chance to review my comments above? |
@sebadoom Sorry for the delay. I am currently experimenting to see if there is another way to get the same information that you get using Uncommenting this line when running the tests gives you a file called |
Any progress on this? Also, it looks like we would need to add http://peter.sh/experiments/chromium-command-line-switches/#enable-precise-memory-info |
As title says. Uses setInterval (is this OK?).