p2psim: Update README, remove meaningless flags in benchmark execution

axieinfinity · Dec 25, 2024 · 5487da5 · 5487da5
1 parent 32a59ce
commit 5487da5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/p2p/simulations/examples/discovery/README.md b/p2p/simulations/examples/discovery/README.md
@@ -80,15 +80,15 @@ INFO [12-24|14:46:39.132] starting simulation server               port=8888
 ```
 
 ``` bash
-$ p2psim node create-multi --count 2 --fake.iplistener --start -node.type bootnode --enable.enrfilter
+$ p2psim node create-multi --count 2 --node.type bootnode --autofill.bootnodes=false
 Created bootnode-1735026417-0
 Started bootnode-1735026417-0
 Created bootnode-1735026417-1
 Started bootnode-1735026417-1
 ```
 
 ``` bash
-$ p2psim node create-multi --count 16 --fake.iplistener --start --autofill.bootnodes --dirty.rate 50 --enable.enrfilter
+$ p2psim node create-multi --count 16 --dirty.rate 50
 Created node-1735026508-0
 Started node-1735026508-0
 Created node-1735026508-1

diff --git a/p2p/simulations/examples/discovery/discovery.sh b/p2p/simulations/examples/discovery/discovery.sh
@@ -65,7 +65,7 @@ while [[ $# -gt 0 ]]; do
             shift 2
             ;;
         --disable.enrfilter)
-            other+=" --enable.enrfilter false"
+            other+=" --enable.enrfilter=false"
             shift
             ;;
         --testname)
@@ -117,13 +117,13 @@ benchmark() {
 
     # Start bootnodes
     echo "Start bootnodes $test_name..."
-    $p2psim_cmd node create-multi --count $num_bootnodes --node.type bootnode $other
+    $p2psim_cmd node create-multi --count $num_bootnodes --node.type bootnode $other --autofill.bootnodes=false
 
     # Roll out batches
     for num_node in ${distribution[@]}; do
         # Roll out nodes
         echo "Start $num_node nodes..."
-        $p2psim_cmd node create-multi --count $num_node --autofill.bootnodes --interval $node_creation_interval --dirty.rate $dirty_rate --only.outbound.rate $only_outbound_rate $other
+        $p2psim_cmd node create-multi --count $num_node --interval $node_creation_interval --dirty.rate $dirty_rate --only.outbound.rate $only_outbound_rate $other
 
         # Wait for a while until the network is stable
         echo "Sleep $sleep_time..."