Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
blockchain: fix the write known block check (#404)
Before commit bf2f0d1 ("blockchain: fix inconsistent reorg behavior"), the write known block only checks the if the external total difficulty (TD) is higher than local one without following the fast finality rule, so it can reorg an justified block. That commit replaces the check with reorgNeeded function to enforce the fast finality rule. However, the reorgNeeded function does not strictly enforce that the external TD is higher than local one, it allows that the external TD may be equal to the local one. This leads to warning with an impossible reorg case. This commit adds back the TD check combining with the reorgNeeded function to correcly enforce the rule here.
- Loading branch information