p2psim: Remove start flag of p2psim node create

cmd/p2psim/main.go

@@ -167,11 +167,6 @@ func main() {
 							Value: "",
 							Usage: "node private key (hex encoded)",
 						},
-						&cli.BoolFlag{
-							Name:  "start",
-							Value: true,
-							Usage: "start the node after creating successfully",
-						},
 						&cli.BoolFlag{
 							Name:  "autofill.bootnodes",
 							Value: true,
@@ -458,15 +453,6 @@ func createNode(ctx *cli.Context) error {
 		return err
 	}
 	fmt.Fprintln(ctx.App.Writer, "Created", node.Name)
-
-	// Start node if needed
-	if ctx.Bool("start") {
-		if err := client.StartNode(node.Name); err != nil {
-			return err
-		}
-		fmt.Fprintln(ctx.App.Writer, "Started", node.Name)
-	}
-
 	return nil
 }
 
@@ -567,14 +553,23 @@ func createMultiNode(ctx *cli.Context) error {
 		}
 		ctx.Set("name", nodeName)
 		for {
-			if err := createNode(ctx); err != nil {
-				fmt.Fprintln(ctx.App.Writer, "Failed to create node", nodeName, err)
-				// Try to create the node again
-				client.DeleteNode(nodeName)
-				time.Sleep(500 * time.Millisecond)
-			} else {
-				break
+			err := createNode(ctx)
+			if err == nil {
+				// Start node if needed
+				if ctx.Bool("start") {
+					err = client.StartNode(nodeName)
+					if err == nil {
+						fmt.Fprintln(ctx.App.Writer, "Started", nodeName)
+						break
+					}
+				}
 			}
+
+			fmt.Fprintln(ctx.App.Writer, "Failed to create node, retrying...", nodeName, err)
+			// Try to create the node again
+			client.DeleteNode(nodeName)
+			time.Sleep(500 * time.Millisecond)
+
 		}
 		if createInterval > 0 {
 			time.Sleep(createInterval)

p2p/simulations/examples/discovery/main.go

@@ -110,6 +110,7 @@ func (s *networkCompatibilityService) Info() interface{} {
 	return nil
 }
 
+// mimic the behavior of the Snap protocol check
 func (s *networkCompatibilityService) Run(peer *p2p.Peer, rw p2p.MsgReadWriter) error {
 	if !peer.RunningCap(s.name, []uint{1}) {
 		log.Error("peer does not support protocol", "peer", peer.ID())