core/state/snapshot: check difflayer staleness early (#27255) #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a staleness-check to AccountRLP, before checking the bloom-filter and potentially going directly into the disklayer. --------- Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
andicrypt
approved these changes
Nov 23, 2023
minh-bq
added a commit
to minh-bq/ronin
that referenced
this pull request
Feb 20, 2024
…finity#383) This PR adds a staleness-check to AccountRLP, before checking the bloom-filter and potentially going directly into the disklayer. --------- Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the flaky unit test TestDiffLayerExternalInvalidationPartialFlatten we sometimes observe. The expected behavior is that we get the error when query account or storage slot from stale diff layer. However, the staleness check is done after the bloom filter check. If we get the bloom filter miss in diff layer, we go directly to disk layer, so we don't go through the staleness check in diff layer. The test is flaky because bloom filter is randomized. This commit moves the staleness check earlier before bloom filter check.
More details at: ethereum/go-ethereum#27254