consortium-v2: make the period definition consistent with contract #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Ronin detects the start of new period is the first block of an epoch where that block's timestamp is on the different date from first block of previous epoch. However, in contract, the start of new period is the first block of epoch where the parent of it (the last block of previous epoch)'s timestamp is on the different date from the last block of "previous previous" epoch. In this commit, we change the Ronin logic to be consistent with contract after Venoki hardfork.
IsPeriodBlock is only called when passing Tripp hardfork already so we don't need to check it further inside the function.
| t.Errorf("wrong period block") | ||
| } | ||
| } | ||
|
|
||
| func generateChain( |
There was a problem hiding this comment.
Could we add some description/purpose for this method with flag bumpTimeStampLastBlockOfEpoch usage for setting the timestamp of lastBlock
huyngopt1994
approved these changes
Dec 10, 2024
chiphamskymavis
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Ronin detects the start of new period is the first block of an epoch
where that block's timestamp is on the different date from first block of
previous epoch. However, in contract, the start of new period is the first block
of epoch where the parent of it (the last block of previous epoch)'s timestamp
is on the different date from the last block of "previous previous" epoch. In
this commit, we change the Ronin logic to be consistent with contract after
Venoki hardfork.