Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/vm, go.mod: update uint256 and use faster method to write to memory (#30868) #650

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

minh-bq
Copy link
Collaborator

@minh-bq minh-bq commented Dec 19, 2024

commit ethereum/go-ethereum@5c58612.

Updates geth to use the uint256 v1.3.2, and use faster memory-writer to speed up MSTORE.

goos: linux
goarch: amd64
pkg: github.com/ethereum/go-ethereum/core/vm
cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
           │   old.txt   │               new.txt               │
           │   sec/op    │   sec/op     vs base                │
OpMstore-8   18.18n ± 8%   12.58n ± 8%  -30.76% (p=0.000 n=10)

Link: holiman/uint256#190

…ory (#30868)

commit ethereum/go-ethereum@5c58612.

Updates geth to use the uint256 v1.3.2, and use faster memory-writer to speed
up MSTORE.

goos: linux
goarch: amd64
pkg: github.com/ethereum/go-ethereum/core/vm
cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
           │   old.txt   │               new.txt               │
           │   sec/op    │   sec/op     vs base                │
OpMstore-8   18.18n ± 8%   12.58n ± 8%  -30.76% (p=0.000 n=10)

Link: holiman/uint256#190
@minh-bq
Copy link
Collaborator Author

minh-bq commented Dec 19, 2024

On CI the PR shows slight improvement in more general benchmarks

goos: linux
goarch: amd64
pkg: github.com/ethereum/go-ethereum/core/vm
cpu: AMD EPYC 7763 64-Core Processor                
                          │   old.txt    │              new.txt               │
                          │    sec/op    │   sec/op     vs base               │
EvmInsertionSort-4          82.51m ± 10%   77.01m ± 3%  -6.67% (p=0.001 n=10)
EvmQuickSort-4              5.146m ±  1%   4.999m ± 1%  -2.86% (p=0.002 n=10)
EvmSignatureValidation-4    11.58µ ±  2%   11.50µ ± 1%       ~ (p=0.247 n=10)
EvmMulticallErcTransfer-4   4.765m ±  1%   4.729m ± 1%       ~ (p=0.063 n=10)
EvmRedBlackTree-4           225.6m ±  2%   223.6m ± 2%       ~ (p=0.123 n=10)
geomean                     5.554m         5.421m       -2.41%

@minh-bq minh-bq merged commit dfbbfea into axieinfinity:master Dec 19, 2024
2 checks passed
@minh-bq minh-bq deleted the mstore branch December 19, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants