Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabular result format #239

Merged

Conversation

lukasmalkmus
Copy link
Collaborator

@lukasmalkmus lukasmalkmus commented Jul 17, 2023

A first iteration for the tabular results format, something we worked on to replace the current response format in the future. This draft serves as a place to discuss, test and iterate on the changes.

Three commits are of particular interest (omitting SHAs/links as we will likely rebase this):

  1. Implements the general format
  2. Provides a generic iterator for columns and rows
  3. Adds stronger typing for ease of use and protection against misuse
  4. Adds support for Go's 1.23 new iter package

@lukasmalkmus lukasmalkmus added enhancement New feature or request help wanted Extra attention is needed labels Jul 17, 2023
@lukasmalkmus lukasmalkmus added this to the v0.17.0 milestone Jul 17, 2023
@lukasmalkmus lukasmalkmus self-assigned this Jul 17, 2023
@lukasmalkmus lukasmalkmus force-pushed the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch from 0e1aa21 to 00ce60d Compare July 18, 2023 14:49
@lukasmalkmus lukasmalkmus force-pushed the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch from 00ce60d to d28430d Compare July 31, 2023 16:49
@lukasmalkmus lukasmalkmus modified the milestones: v0.17.0, v0.19.0 Sep 1, 2023
@lukasmalkmus lukasmalkmus force-pushed the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch 2 times, most recently from 89f882c to bcf2423 Compare October 18, 2023 09:45
@lukasmalkmus lukasmalkmus force-pushed the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch 4 times, most recently from 445262f to 170da3a Compare April 15, 2024 14:12
@lukasmalkmus lukasmalkmus modified the milestones: v0.19.0, v0.20.0 May 29, 2024
@lukasmalkmus lukasmalkmus force-pushed the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch 3 times, most recently from f6a663a to 19e1d8a Compare August 10, 2024 13:54
axiom/query/field.go Outdated Show resolved Hide resolved
@lukasmalkmus lukasmalkmus force-pushed the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch from 88cc7fc to a1fa476 Compare August 12, 2024 16:30
@SollyzDev SollyzDev force-pushed the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch from fae5242 to ce78037 Compare August 13, 2024 11:31
@lukasmalkmus lukasmalkmus force-pushed the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch from 166ac19 to 23d9042 Compare August 14, 2024 12:18
@SollyzDev SollyzDev force-pushed the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch 3 times, most recently from 40b6e30 to cbe04aa Compare August 16, 2024 12:27
bahlo
bahlo previously approved these changes Aug 19, 2024
Copy link
Member

@bahlo bahlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy iterators ✨

@kamstrup
Copy link

Fancy iterators ✨

Only if it comes from the French region of Iteráteur; otherwise it's just sparkling for-loops

@lukasmalkmus lukasmalkmus force-pushed the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch from 47a43ca to efd08b8 Compare September 17, 2024 10:22
@lukasmalkmus lukasmalkmus marked this pull request as ready for review September 17, 2024 10:54
Copy link
Member

@bahlo bahlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@lukasmalkmus lukasmalkmus merged commit d880ac0 into main Sep 17, 2024
24 checks passed
@lukasmalkmus lukasmalkmus deleted the lukasmalkmus/dx-457-tabular-result-format-support-for-axiom branch September 17, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants