Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): drop retry/backoff functionality #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukasmalkmus
Copy link
Collaborator

No description provided.

@lukasmalkmus lukasmalkmus self-assigned this Apr 2, 2024
@lukasmalkmus lukasmalkmus added the enhancement New feature or request label Apr 2, 2024
@lukasmalkmus lukasmalkmus requested a review from bahlo April 2, 2024 08:57
@lukasmalkmus lukasmalkmus added this to the v0.18.0 milestone Apr 2, 2024
@lukasmalkmus lukasmalkmus marked this pull request as ready for review April 2, 2024 09:19
axiom/client.go Outdated Show resolved Hide resolved
_ = resp.Body.Close()

// Reset the requests body, so it can be re-read.
if req.Body, err = req.GetBody(); err != nil {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also drop any code that sets GetBody.

@lukasmalkmus lukasmalkmus modified the milestones: v0.18.0, v0.19.0 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants