Avoid triggering django.setup() when importing settings. #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelLefkowitz
added
enhancement
1.21.x
creyD
approved these changes
Jul 20, 2022
koniiiik
force-pushed
the
avoid-triggering-django-setup-on-settings-import
branch
from
f2f97b2
to
e8d1b7c
Compare
koniiiik
force-pushed
the
avoid-triggering-django-setup-on-settings-import
branch
from
e8d1b7c
to
5b65255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing the module
drf_yasg.app_settingshas a side effect of immediately triggeringdjango.setup()once the call togetattr(settings, "LOGIN_URL", None)is encountered. This makes it impossible to import the default YASG settings at the beginning of your Django settings module in order to extend some of the default values with application-specific customizations.This patch wraps the
LOGIN_URLfallback into a lazy string object to delay the evaluation of Django settings.