Fix 765 - Update to ruamel.yaml 0.17, use new API #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.17.0 drops Python 2.7 support, and sets 3.5 as the minimum. Adds a deprecation warning for dump() and load(), used in codec.py. This is followed by rapid releases to 0.17.2 to fix packaging issues.
Convert from `yaml.load` and `yaml.dump` to a YAML instance, and prefer features in that library. * SaneYamlDumper becomes SaneYamlRepresenter, based on SafeRepresenter * increase_indent is dropped in favor of calling indent() * represent_odict is dropped in favor of using represent_dict with setting sort_base_mapping_on_output to FalseA * Drop block style for bytes * Encode to binary after processing, rather than setting on YAML instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements YAML loading and unloading using the
ruamel.yamlAPI introduced in 0.15. The older PyYAML-based API is deprecated in 0.17. This fixes issue #765 and the deprecation warnings.Much of the YAML code was in the initial commit in 2017. Since then,
ruamel.yamlhas implemented fixes and features that removes the need for a lot of the custom code.I tested by:
toxtestprojapp before and after the change. The YAML is identical.