Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc flag fixes #83

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Misc flag fixes #83

merged 6 commits into from
Nov 20, 2024

Conversation

fekete-robert
Copy link
Contributor

No description provided.

@MrAnno
Copy link
Member

MrAnno commented Nov 18, 2024

Sorry, let me clarify what we've discussed:

Both store-legacy-msghdr and dont-store-legacy-msghdr are available as general source flags, but the default is store-legacy-msghdr. This means setting dont-store-legacy-msghdr will change the default behavior, setting the other option does not make sense unless someone is afraid that we might change the defaults.

I think we should not remove store-legacy-msghdr from the doc, we could just state the default behavior instead.


Python:
When configuring a Python source, both flags are available, but on the Python side, this is published as store-legacy-msghdr (there is no dont alternative).

This information is only useful in the writing server-style Python sources and in the writing fetcher-style Python sources chapter, but we haven't documented the flags field there yet.

@fekete-robert fekete-robert requested a review from MrAnno November 19, 2024 15:24
@fekete-robert fekete-robert marked this pull request as ready for review November 20, 2024 06:37
@fekete-robert fekete-robert merged commit 6f5f5e5 into main Nov 20, 2024
1 check passed
@fekete-robert fekete-robert deleted the misc-flag-fixes branch November 20, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants