Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/ivykis: update ivykis to include the epoll_pwait2() fix #130

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

bazsi
Copy link
Member

@bazsi bazsi commented May 28, 2024

ivykis 0.43 started supporting epoll_pwait2() which is not permitted in docker environments in older distributions (RHEL7 came up, as well as Debian buster)

This branch updates our ivykis submodule to a branch in the ivykis upstream, which will hopefully be released as 0.43.1 soon enough.

I'd wait a few days for ivykis 0.43.1 to be released, once that happens we could use the official commit. @buytenh

@buytenh
Copy link

buytenh commented Jun 1, 2024

I merged the ivykis fix referenced in this PR to the ivykis master branch, so the commit ID should remain stable.

I'm going to try to see if I will have some time this weekend to reproduce and maybe fix buytenh/ivykis#32 . If I manage that, I'll release 0.43.1 with a fix for that issue included.

Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi bazsi force-pushed the fix-update-ivykis-to-0.43.1 branch from 632912c to 93784a8 Compare June 2, 2024 09:45
@bazsi
Copy link
Member Author

bazsi commented Jun 2, 2024

I've updated this branch to contain both patches. The official tag is not there, but both of the patches are on master already, so this should be good enough for merging without changing the submodule ref.

@alltilla
Copy link
Member

alltilla commented Jun 3, 2024

https://github.com/buytenh/ivykis/tree/v0.43.1 was released a couple of hours ago. I think it would be best to update to that tag.

@buytenh
Copy link

buytenh commented Jun 3, 2024

https://github.com/buytenh/ivykis/tree/v0.43.1 was released a couple of hours ago. I think it would be best to update to that tag.

Note that the v0.43.1-trunk tag is the release tag on the master branch, while v0.43.1 is a tag based on that which corresponds to the generated release tarball, meaning that it has all the autogenerated autoconf files in it.

Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
@alltilla alltilla force-pushed the fix-update-ivykis-to-0.43.1 branch from b01aebb to dd56517 Compare June 3, 2024 09:11
@alltilla
Copy link
Member

alltilla commented Jun 3, 2024

Thanks for the heads up, I updated to v0.43.1-trunk.

@alltilla alltilla merged commit ee6232f into axoflow:main Jun 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants