metrics: factor out TLS cache #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAnno
previously approved these changes
Jun 17, 2024
bazsi
reviewed
Jun 22, 2024
lib/metrics/metrics-tls-cache.c
Outdated
| @@ -84,15 +84,15 @@ _deinit_tls_clusters_map_thread_init_hook(gpointer user_data) | |||
| } | |||
|
|
|||
| static void | |||
| _init_tls_clusters_map_apphook(gint type, gpointer user_data) | |||
| _init_tls_clusters_map_apphook(void) | |||
There was a problem hiding this comment.
If I understand correctly, this is not an apphook anymore, so maybe remove that from the name.
bazsi
reviewed
Jun 22, 2024
| @@ -144,14 +144,13 @@ metrics_tls_cache_get_labels_len(void) | |||
| void | |||
| metrics_tls_cache_global_init(void) | |||
There was a problem hiding this comment.
maybe this is a bit too granular for apphook, and we should just have a metrics_global_init()/deinit() functions.
e.g. drop the tls_cache piece from the name. if there will be multiple metrics related global init/deinit chores, we could call all of those from a single metrics_global_init() function.
bazsi
reviewed
Jun 22, 2024
lib/metrics/metrics-tls-cache.c
Outdated
| } | ||
|
|
||
| StatsClusterLabel * | ||
| metrics_tls_cache_get_next_label(void) |
There was a problem hiding this comment.
[optional] this is more like an alloc() function. get_next_label() seems like a read only operation. I needed to check out the implementation to understand what it was doing exactly.
bazsi
reviewed
Jun 22, 2024
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
metrics-tls-cache
branch
from
e116770 to
6a0edda
Compare
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
metrics-tls-cache
branch
from
6a0edda to
f890a2f
Compare
bshifter
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.