Debugger filterx #356
Open
Debugger filterx #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
debugger-filterx
branch
from
99c2015 to
225043f
Compare
Instead of using "NULL" as the indicator for the end of the lines to print, just pass the number of entries in the lines array. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
The mode field in debugger determines how we respond to trace and breakpoints and is used by the hook to trigger various debugging scenarios. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Some breakpoints are not interesting once the mode changes, even though they were submitted by the pipe hook and are waiting to be resumed. Let's quickly acknowledge them and don't bother the user. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Also, stop at the prompt immediately, instead of wait for a message. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
bazsi
force-pushed
the
debugger-filterx
branch
from
225043f to
c61fe7d
Compare
This is not a fastpath, so we can use atomics and the debugger needs to ref/unref expressions in the debugger thread, which causes failed assertions. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Instead of returning a fully formed compound expression, just return the list of expressions, so the brace is processed by the parent grammar. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Exclude other threads simply by only allowing these calls to be made while parsing is in progress, which is inherently single-threaded. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
bazsi
force-pushed
the
debugger-filterx
branch
from
c61fe7d to
f4d3ba1
Compare
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Which returns a borrowed string instead of an EVTTAG. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
bazsi
force-pushed
the
debugger-filterx
branch
from
f4d3ba1 to
bcd453e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the printx/px commands to the debugger which evaluates a filterx expression.
This should go in after #340