filterx: update_metrics() and flatten() perf improvements
#365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alltilla
force-pushed
the
update-metrics-perf-improvement
branch
3 times, most recently
from
4619ede to
f3ff24c
Compare
MrAnno
reviewed
Nov 15, 2024
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Getting it has a performance overhead, we should minimize it. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
This class will be used for performance optimization purposes. When we know beforehand that we are constructing a label set for an upcoming update_metric() call, we can gather the labels to a specialized container, directly as `StatsClusterLabel`s. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
…el() Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
added a commit
to alltilla/axosyslog
that referenced
this pull request
Nov 15, 2024
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
update-metrics-perf-improvement
branch
from
f3ff24c to
caadec4
Compare
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
…order Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
It reduced the number of malloc calls. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
update-metrics-perf-improvement
branch
from
caadec4 to
db02c39
Compare
MrAnno
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.