-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check program name for rfc3164 #380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Pull Request introduces config grammar changesaxoflow/0b99654805acc81e18d5d0cf1c6c3e25fac92b9d -> bshifter/logmsg-check-program --- a/options
+++ b/options
global-options(
+ check-program(<yesno>)
)
--- a/parser
+++ b/parser
syslog-parser(
flags(
+ check-program
)
)
--- a/source
+++ b/source
fifo(
+ check-program(<yesno>)
flags(
+ check-program
)
)
file(
+ check-program(<yesno>)
flags(
+ check-program
)
)
network(
+ check-program(<yesno>)
flags(
+ check-program
)
)
pipe(
+ check-program(<yesno>)
flags(
+ check-program
)
)
program(
+ check-program(<yesno>)
flags(
+ check-program
)
)
stdin(
+ check-program(<yesno>)
flags(
+ check-program
)
)
syslog(
+ check-program(<yesno>)
flags(
+ check-program
)
)
systemd-syslog(
+ check-program(<yesno>)
flags(
+ check-program
)
)
tcp(
+ check-program(<yesno>)
flags(
+ check-program
)
)
tcp6(
+ check-program(<yesno>)
flags(
+ check-program
)
)
udp(
+ check-program(<yesno>)
flags(
+ check-program
)
)
udp6(
+ check-program(<yesno>)
flags(
+ check-program
)
)
unix-dgram(
+ check-program(<yesno>)
flags(
+ check-program
)
)
unix-stream(
+ check-program(<yesno>)
flags(
+ check-program
)
)
wildcard-file(
+ check-program(<yesno>)
flags(
+ check-program
)
)
|
bshifter
changed the title
axorouter-framework: check program name for rfc3164
check program name for rfc3164
Nov 14, 2024
bshifter
force-pushed
the
logmsg-check-program
branch
from
November 14, 2024 14:09
4bd3790
to
fd113ac
Compare
MrAnno
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
(We may also need a NEWS file entry).
bshifter
force-pushed
the
logmsg-check-program
branch
from
November 15, 2024 15:43
fd113ac
to
ad3a54d
Compare
MrAnno
reviewed
Nov 18, 2024
LGTM. We can merge it after adding a news entry. |
Signed-off-by: shifter <shifter@axoflow.com>
Signed-off-by: shifter <shifter@axoflow.com>
Signed-off-by: shifter <shifter@axoflow.com>
Signed-off-by: shifter <shifter@axoflow.com>
bshifter
force-pushed
the
logmsg-check-program
branch
2 times, most recently
from
November 18, 2024 14:40
651e705
to
889b8b7
Compare
MrAnno
previously approved these changes
Nov 18, 2024
Signed-off-by: shifter <shifter@axoflow.com>
bshifter
force-pushed
the
logmsg-check-program
branch
from
November 18, 2024 14:59
889b8b7
to
6fbb002
Compare
MrAnno
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check-program flag was added to validate the program field in syslog format. It verifies that the program field contains only the allowed characters '[a-zA-Z0-9].-_/()' and requires at least one alphabetical character in the program name. If these conditions are not met, it treats the program field and the remaining fields as part of the log message. This approach avoids using regular expressions to improve performance.
examples: