Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix macOS dep conflict #387

Merged
merged 1 commit into from
Nov 25, 2024
Merged

ci: fix macOS dep conflict #387

merged 1 commit into from
Nov 25, 2024

Conversation

MrAnno
Copy link
Member

@MrAnno MrAnno commented Nov 22, 2024

pkgconf is a newer, actively maintained implementation of pkg-config.

This is to fix CI on certain macOS runner instances (not all of them are affected). pkg-config is now migrated to pkgconf in brew, but a few runners have old pkg-config installed in a way they can't be overwritten by just a simple upgrade.

@MrAnno MrAnno force-pushed the fix-ci-macos branch 2 times, most recently from 3b21d18 to 49f3510 Compare November 22, 2024 11:09
@MrAnno MrAnno marked this pull request as draft November 22, 2024 11:29
@MrAnno MrAnno marked this pull request as ready for review November 22, 2024 11:31
@MrAnno MrAnno force-pushed the fix-ci-macos branch 2 times, most recently from 1094fd6 to 64c2d48 Compare November 22, 2024 12:53
pkgconf is a newer, actively maintained implementation of pkg-config.

Signed-off-by: László Várady <laszlo.varady@anno.io>
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

FTR: They did the same switch here as well Homebrew/homebrew-core@eacd290 (#197590)

@OverOrion OverOrion merged commit e52373d into axoflow:main Nov 25, 2024
23 checks passed
@MrAnno MrAnno removed the request for review from bshifter November 25, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants