FilterX expression eval metrics #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAnno
force-pushed
the
filterx-expr-metrics
branch
from
4467917 to
63569a9
Compare
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Nov 28, 2024
Signed-off-by: László Várady <laszlo.varady@anno.io>
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Nov 28, 2024
Signed-off-by: László Várady <laszlo.varady@anno.io>
MrAnno
force-pushed
the
filterx-expr-metrics
branch
from
35791aa to
10dd75e
Compare
MrAnno
added a commit
to MrAnno/axosyslog
that referenced
this pull request
Nov 28, 2024
Signed-off-by: László Várady <laszlo.varady@anno.io>
MrAnno
force-pushed
the
filterx-expr-metrics
branch
from
10dd75e to
815384e
Compare
alltilla
previously approved these changes
Nov 29, 2024
MrAnno
dismissed
alltilla’s stale review
The merge-base changed after approval.
|
I might consider introducing the name field in Nevertheless, this is extremely useful as it is, so approve from me :) |
|
That was the original idea, but I was really missing the expression type from the metric names (operator, function, etc.), but I didn't want to store that as a string in the expression, so I ended up with this boilerplate. |
Signed-off-by: László Várady <laszlo.varady@anno.io>
For metrics, but it is also useful for debugging and internal logging. Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
MrAnno
force-pushed
the
filterx-expr-metrics
branch
from
815384e to
9ba3447
Compare
alltilla
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #395