Filterx performance improvements

[bazsi]

These are the smaller micro optimizations I was doing on filterx_expr_eval(). The improvement:

branch:

(dbld)bazsi@bzorp2:/source$ /install/bin/loggen -r 1000000 -s 256 -I 10 -S localhost 2000  
average rate = 90635.76 msg/sec, count=952000, time=10.5036, (average) msg size=256, bandwidth=22658.94 kB/sec
(dbld)bazsi@bzorp2:/source$ /install/bin/loggen -r 1000000 -s 256 -I 10 -S localhost 2000  
average rate = 97369.38 msg/sec, count=974000, time=10.0031, (average) msg size=256, bandwidth=24342.34 kB/sec
(dbld)bazsi@bzorp2:/source$ /install/bin/loggen -r 1000000 -s 256 -I 10 -S localhost 2000  
average rate = 94165.86 msg/sec, count=989000, time=10.5027, (average) msg size=256, bandwidth=23541.46 kB/sec

main (e654f38):

(dbld)bazsi@bzorp2:/source$ /install/bin/loggen -r 1000000 -s 256 -I 10 -S localhost 2000  
average rate = 65314.82 msg/sec, count=686000, time=10.503, (average) msg size=256, bandwidth=16328.70 kB/sec
(dbld)bazsi@bzorp2:/source$ /install/bin/loggen -r 1000000 -s 256 -I 10 -S localhost 2000  
average rate = 64745.14 msg/sec, count=680000, time=10.5027, (average) msg size=256, bandwidth=16186.28 kB/sec
(dbld)bazsi@bzorp2:/source$ /install/bin/loggen -r 1000000 -s 256 -I 10 -S localhost 2000  
average rate = 65125.94 msg/sec, count=684000, time=10.5027, (average) msg size=256, bandwidth=16281.48 kB/sec

[MrAnno]

Can you please share your configuration as well?

(I tried to measure the perf diff of this branch using our internal configs without success.)

$ bin/loggen -r 1000000 -s 256 -I 20 -S localhost 514 #bazsi:filterx-performance-improvements
average rate = 15313.40 msg/sec

$ bin/loggen -r 1000000 -s 256 -I 20 -S localhost 514 #main
average rate = 14984.77 msg/sec

[bazsi]

Oh, I didn't see the review results, and push a couple more patches. Can you re-approve?

My config was a lot simpler:

@version: current

log {
	source { tcp(port(2000) flags(no-parse) log-iw-size(10k) log-fetch-limit(10k)); };

	filterx {
		meta = json();
		meta.splunk = json();
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
		meta.splunk.index = "foo";
		meta.splunk.host = "bar";
		meta.splunk.sourcetype = "baz";
		meta.splunk.sourcetype = "bax";
	};

	destination { file("/dev/null"); };
};

Also I noticed that my CPU governor was playing tricks

[MrAnno]

Thank you. I will do my usual measurements too, but I don't see a reason to delay the merge of these commits.