Filterx regexp_subst match group changes #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshifter
force-pushed
the
fx-rgx-subst-matchgrps
branch
from
3826e2f to
bb55648
Compare
Merged
|
Really cool, thanks for this!
I might have miscommunicated this, sorry if so. |
…to allow up to 3 digits. The parser now supports up to 3 digits for match group references. If the reference exceeds this limit, the parser exits and treats it as a 3-digit reference. This change prevents excessive greediness in processing match group references and improves performance by limiting the reference size. Additionally, match groups can now include leading zeros, allowing users to reference match groups with fewer than 3 digits before alphanumeric characters. For example, \100000000 will be parsed as match group 100, but by using a prefix like \00100000000, the parser will correctly identify it as match group 1. Signed-off-by: shifter <shifter@axoflow.com>
Signed-off-by: shifter <shifter@axoflow.com>
bshifter
force-pushed
the
fx-rgx-subst-matchgrps
branch
5 times, most recently
from
2ed52df to
1a0ad06
Compare
…present The function now automatically checks the replacement pattern at config parsing time. If no match group references are found in the pattern, it will behave as if the 'groups' option is disabled, disabling match group functionality for performance reasons. By default, match groups are enabled in regexp_subst. However, this behavior can now be explicitly disabled by setting the optional named argument groups=false, as shown: `regexp_subst(target, match_pattern, replace_pattern, groups=false);` Signed-off-by: shifter <shifter@axoflow.com>
Signed-off-by: shifter <shifter@axoflow.com>
bshifter
force-pushed
the
fx-rgx-subst-matchgrps
branch
from
1a0ad06 to
231c51a
Compare
alltilla
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #405
groupsinverted and renamed tonogroups