-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grpc service accounts #412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Pull Request introduces config grammar changesaxoflow/62228cd45e7744ded91a839c6893c8b2835c50f5 -> sodomelle/grpc-service-accounts --- a/destination
+++ b/destination
axosyslog-otlp(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
bigquery(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
clickhouse(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
google-pubsub-grpc(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
loki(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
opentelemetry(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
syslog-ng-otlp(
auth(
+ service-account(
+ <empty>
+ key(<path>)
+ token-validity-duration(<number>)
+ )
)
)
|
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 7, 2024
Signed-off-by: Tamás Kosztyu <tamas.kosztyu@axoflow.com>
sodomelle
force-pushed
the
grpc-service-accounts
branch
from
December 7, 2024 10:40
0c88974
to
b17f698
Compare
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 7, 2024
Signed-off-by: Tamás Kosztyu <tamas.kosztyu@axoflow.com>
sodomelle
force-pushed
the
grpc-service-accounts
branch
from
December 7, 2024 10:46
b17f698
to
0ef5c9e
Compare
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 9, 2024
Signed-off-by: Tamás Kosztyu <tamas.kosztyu@axoflow.com>
sodomelle
force-pushed
the
grpc-service-accounts
branch
from
December 9, 2024 10:23
0ef5c9e
to
7c6842f
Compare
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Tamás Kosztyu <tamas.kosztyu@axoflow.com>
sodomelle
force-pushed
the
grpc-service-accounts
branch
from
December 10, 2024 08:43
7c6842f
to
07df96e
Compare
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Tamás Kosztyu <tamas.kosztyu@axoflow.com>
sodomelle
force-pushed
the
grpc-service-accounts
branch
from
December 10, 2024 14:59
07df96e
to
8cdcc06
Compare
Signed-off-by: Tamás Kosztyu <tamas.kosztyu@axoflow.com>
Signed-off-by: Tamás Kosztyu <tamas.kosztyu@axoflow.com>
sodomelle
added a commit
to sodomelle/axosyslog
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Tamás Kosztyu <tamas.kosztyu@axoflow.com>
sodomelle
force-pushed
the
grpc-service-accounts
branch
from
December 10, 2024 15:00
8cdcc06
to
d808a0c
Compare
alltilla
previously approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor news entry related comments, otherwise approve!
Signed-off-by: Tamás Kosztyu <tamas.kosztyu@axoflow.com>
sodomelle
force-pushed
the
grpc-service-accounts
branch
from
December 13, 2024 08:48
d808a0c
to
9734e52
Compare
alltilla
approved these changes
Dec 13, 2024
macOS is failing on main, too, it is not caused by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like gRPC sets the audience and scope options based on the gRPC service name, so they can't be set in the config.
Example usage: