Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach project binaries to releases for accessibility #274

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

holysoles
Copy link
Contributor

This PR serves to address some of the issues with accessing the compiled binaries for this project. By generating releases for this project and attaching binaries to them, it should work around workflow artifacts expiring and any issues with binaries in the repo itself.

Included changes:

  • bump the version of the upload-artifact version to a supported one
  • change the existing build action to only run on PR events. This includes PRs being opened, additional commits being added to the source branch, etc
  • add a new workflow that supports a release workflow

This would require that after merges to master, a maintainer go generate a release for the project, and associated git tag. That will trigger this new workflow and upload the built binaries (unzipped) to the release.

I've tested this on my fork:

@ayoubfaouzi
Copy link
Owner

Hello @holysoles

Good stuff ! Thank you.

A couple of suggestion:

  • You can safely delete the appveyor.yml, we don't use it anymore
  • For the release workflow, we still need to zip the artifacts to avoid detection and potential blocking of the page. You can use the same command in the build workflow to zip it and you can also use the same password.

Once done, I will merge it and make a release. We never made any release so far :)

@holysoles holysoles changed the title Attach project binaries to releases for accessibility WIP: Attach project binaries to releases for accessibility Sep 21, 2024
@holysoles
Copy link
Contributor Author

holysoles commented Sep 21, 2024

@LordNoteworthy thanks for the quick reply! Feedback implemented and I squashed my commits

Example that uses 7z is here: https://github.com/holysoles/al-khaser/releases/tag/v1.0.1

@holysoles holysoles changed the title WIP: Attach project binaries to releases for accessibility Attach project binaries to releases for accessibility Sep 21, 2024
@ayoubfaouzi
Copy link
Owner

Great work ! I Appreciate the help on this, merging it 🚀

@ayoubfaouzi ayoubfaouzi merged commit 680b623 into ayoubfaouzi:master Sep 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants