Fix conditional compilation of diesel macros #156
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
0.11.0-rc1
, bcbb48d specifically, a bug was introduced, causing onediesel
macro not being excluded from compilation even if theblocking
feature is not enabled. The line added in the referenced commit is: https://github.com/ayrat555/fang/blame/2847db35a690f3c58d5e26bb48bf2c1418cf4849/fang/src/lib.rs#L152The resulting error when trying to compile with
is:
The solution I suggest is to only include this instance of the diesel macro when the blocking feature is enabled.