Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Standardisation of the interface of the functions of the module distributions #40

Closed
victormvy opened this issue Jan 26, 2024 · 3 comments · Fixed by #60
Closed

[API] Standardisation of the interface of the functions of the module distributions #40

victormvy opened this issue Jan 26, 2024 · 3 comments · Fixed by #60
Assignees
@victormvy
Labels
API design API design & software architecture

Comments

@victormvy
Copy link
Contributor

Some functions in the distributions module compute the soft labels for a single target (get_beta_probabilities) while others compute the soft labels for all J classes. Therefore, some functions return a vector while others return a 2d matrix. It should be standardised.
@victormvy victormvy added the API design API design & software architecture label Jan 26, 2024
@victormvy victormvy mentioned this issue Jan 26, 2024
Merged
@victormvy victormvy changed the title standardisation of the interface of the functions of the module distributions [API] Standardisation of the interface of the functions of the module distributions Mar 26, 2024
@victormvy victormvy linked a pull request Apr 15, 2024 that will close this issue
[API] Changed get_beta_softlabels interface to match the others #60
Merged
@victormvy victormvy mentioned this issue Apr 15, 2024
Merged
@victormvy
Copy link
Contributor Author

I have updated the get_beta_softlabels function as suggested. The unittests still need to be updated.

@victormvy
Copy link
Contributor Author

Tests have also been updated

@franberchez
Copy link
Contributor

Thank you again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victormvy victormvy

Labels
API design API design & software architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[API] Changed get_beta_softlabels interface to match the others ayrna/dlordinal
2 participants
@victormvy @franberchez