Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Changed get_beta_softlabels interface to match the others #60

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

victormvy
Copy link
Contributor

@victormvy victormvy commented Apr 15, 2024

Changed get_beta_softlabels interface to match the other soft labelling functions. More precisely, previously, get_beta_softlabels returned a vector of J elements (the soft label associated with the p, q and a parameters received). Now, it only receives J and params_set as parameters and returns all the soft labels for a problem with J classes (J x J matrix).

Suggested in #40.

@victormvy victormvy changed the title Changed get_beta_softlabels interface to match the others [API] Changed get_beta_softlabels interface to match the others Apr 15, 2024
@victormvy victormvy added the API design API design & software architecture label Apr 15, 2024
@victormvy victormvy marked this pull request as ready for review April 16, 2024 06:39
@victormvy victormvy requested a review from franberchez April 16, 2024 06:40
Copy link
Contributor

@franberchez franberchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes have to be done but great work!

@franberchez franberchez merged commit 0396cc1 into development Apr 16, 2024
5 checks passed
@victormvy victormvy deleted the beta_soft_labels branch July 24, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API design API design & software architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Standardisation of the interface of the functions of the module distributions
2 participants