Estimator removal #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victormvy
reviewed
Apr 23, 2024
README.md
Outdated
| @@ -3,8 +3,6 @@ | |||
| `dlordinal` is an open-source Python toolkit focused on deep learning with ordinal methodologies. It is compatible with | |||
There was a problem hiding this comment.
dlordinal is not directly compatible with scikit-learn. However, all the methods implemented in dlordinal can be used in classes that implement the scikit-learn estimator interface.
There was a problem hiding this comment.
Thank you very much for the revision! This part has been corrected.
victormvy
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After careful consideration associated to issue #66, it has been decided to remove the implemented estimator as it was too basic for our current needs. Instead, it has been developed a tutorial showcasing the compatibility of
dlordinalwith third-party packages such asSkorch.