Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fixed CLM numerical instability #70

Merged
merged 2 commits into from
Jun 13, 2024
Merged

[BUG] Fixed CLM numerical instability #70

merged 2 commits into from
Jun 13, 2024

Conversation

RafaAyGar
Copy link
Contributor

Proposed fix for numerical instability of CLM layer #69

@RafaAyGar RafaAyGar added the bug Something isn't working label Jun 6, 2024
@RafaAyGar RafaAyGar self-assigned this Jun 6, 2024
@victormvy victormvy linked an issue Jun 6, 2024 that may be closed by this pull request
[BUG] Numerical instability in CLM activation layer #69
Closed
victormvy
victormvy requested changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@victormvy victormvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It may be interesting to add a warning that shows the first time that the value of z3 before clipping is out of the [-10, 10] range. Then, you can also add a parameter for suppressing the warning.

@victormvy victormvy merged commit 406f9c1 into ayrna:main Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victormvy victormvy victormvy approved these changes

Assignees

@RafaAyGar RafaAyGar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Numerical instability in CLM activation layer
2 participants
@RafaAyGar @victormvy